Feat/gpu flavors tapc 5145 #19959
Merged
Feat/gpu flavors tapc 5145 #19959
+893
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoncarbonnel
changed the base branch from
master
to
feat/add-instance-creation-page-TAPC-4445
github-actions
bot
added
translation required
universe-public-cloud
feature
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
2 times, most recently
from
f1ee7c1 to
0fc19e2
Compare
github-actions
bot
added
the
has conflicts
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
from
0fc19e2 to
5b7c2d2
Compare
github-actions
bot
removed
the
has conflicts
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
3 times, most recently
from
4351e74 to
876c56a
Compare
manoncarbonnel
requested review from
Tsiorifamonjena,
aTurmo,
fredericvilcot,
lionel95200x,
lolottetheclash and
ppprevost
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
2 times, most recently
from
517a814 to
3e45c38
Compare
github-actions
bot
added
the
has conflicts
Tsiorifamonjena
approved these changes
Oct 31, 2025
...s/manager/apps/pci-instances/src/pages/instances/create/components/flavor/FlavorRowUtils.tsx
Outdated
Show resolved
Hide resolved
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
3 times, most recently
from
05a25f5 to
180fe31
Compare
github-actions
bot
removed
the
has conflicts
lolottetheclash
approved these changes
Oct 31, 2025
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
4 times, most recently
from
89689ef to
7080290
Compare
ref: #TAPC-5145 #TAPC-5217 Signed-off-by: Manon Carbonnel <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]> Signed-off-by: Manon Carbonnel <[email protected]>
manoncarbonnel
force-pushed
the
feat/gpu-flavors-TAPC-5145
branch
from
7080290 to
63d3454
Compare
aTurmo
reviewed
Oct 31, 2025
Comment on lines
+31
to
+32
| const list = | ||
| selectedCategory === 'Cloud GPU' ? mockedGpuFlavors : mockedFlavors; |
There was a problem hiding this comment.
Question (could be blocking): is it normal that there are mocked values here ?
There was a problem hiding this comment.
yes for now it is, but real data are coming soon, after modeling
manoncarbonnel
merged commit 6f2754b
into
feat/add-instance-creation-page-TAPC-4445
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding special columns for
Cloud GPUcategory of FlavorsTicket Reference: #TAPC-5145 #TAPC-5217
Screenshots